18 Commits

Author SHA1 Message Date
renovatebot 7de2ee4cfc fix(deps): update module golang.org/x/text to v0.37.0 2026-05-09 17:00:47 +00:00
thuanle 0a1a61d8d3 update sticker id
Build Docker Image / build (amd64) (push) Successful in 1m3s
2026-04-27 10:08:37 +07:00
thuanle 5912157ed1 Merge branch 'main' of ssh://git.thuanle.me:2222/public/crypto-price-bot
Build Docker Image / build (amd64) (push) Failing after 32s
2026-04-27 09:59:13 +07:00
thuanle c5ff494e13 Merge pull request 'refactor: standardize market file naming by data dimension' (#27) from worktree-issue-26-go-filename-consistency into main
Build Docker Image / build (amd64) (push) Successful in 1m38s
Reviewed-on: #27
2026-04-27 09:53:34 +07:00
thuanle 617b067203 chore: address review for market filename refactor
Rename pair tests to match post-refactor boundaries and remove unused alpha cache refresh helper.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
2026-04-27 09:51:24 +07:00
thuanle f5e2e178e1 refactor: standardize market filenames by data dimension
Split market pair logic into spot and futures files and rename price files to plural data-dimension names without changing behavior.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
2026-04-27 07:04:37 +07:00
thuanle bc99d40713 docs: broaden spec to repo-wide go filename consistency
Update issue #26 design scope from market-only to repository-wide .go filename refactor while keeping behavior unchanged.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
2026-04-27 05:14:49 +07:00
thuanle 8010a00e4d docs: add market filename refactor design spec
Capture approved design for issue #26 to standardize market package filenames by data dimension without behavior changes.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
2026-04-27 05:12:35 +07:00
thuanle 259a630b78 giảm file 2026-04-27 05:03:05 +07:00
thuanle f64a3521c4 remove redundant file 2026-04-27 05:03:05 +07:00
thuanle 635b0c5b39 Merge pull request 'fix: recognize spot-only tokens in IsToken' (#25) from fix/issue-24-is-token-spot-only into main
Build Docker Image / build (amd64) (push) Successful in 1m1s
Reviewed-on: #25
2026-04-27 05:00:41 +07:00
thuanle d6338fa092 fix: preserve futures token identity in canonical cache
Keep futureToken2Symbol keyed by raw futures token and use explicit spot-to-future alias mapping during resolver fallback lookups.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
2026-04-27 04:53:54 +07:00
thuanle 711721c1ee refactor: use canonical token-to-symbol maps for market lookup
Build canonical spot/future token maps with quote priority, unify cache refresh scheduling, and switch resolver/token tests to map-based token lookups.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
2026-04-27 04:44:30 +07:00
thuanle 06c40ef30f refactor: separate direct and related spot resolvers
Keep IsToken checks explicit across futures and direct spot symbols, move futures-derived spot mapping to a clearly named helper, and update token data collection to use related spot resolution.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
2026-04-27 04:10:06 +07:00
thuanle 0705e909dc fix: recognize spot-only tokens in IsToken
Gate token detection via spot symbol resolution so chat flow accepts spot-only tokens, and add regression coverage for the fallback path.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
2026-04-27 03:59:32 +07:00
thuanle 72bbe66c3e Merge pull request 'Refactor Binance symbol resolver' (#23) from binance-symbol-resolver-refactor into main
Build Docker Image / build (amd64) (push) Successful in 1m39s
Reviewed-on: #23
Reviewed-by: claudecode <38+claudecode@noreply.localhost>
2026-04-27 03:54:01 +07:00
thuanle 252e77c000 test binance symbol resolver 2026-04-27 03:46:46 +07:00
thuanle 2c5a9e23bf refactor binance symbol resolver 2026-04-27 03:32:59 +07:00
20 changed files with 572 additions and 178 deletions
+2
View File
@@ -1,2 +1,4 @@
/.env /.env
/.worktrees/ /.worktrees/
.DS_Store
.idea/
@@ -0,0 +1,85 @@
# Go filenames consistency design
## Context
The repository has inconsistent `.go` filename semantics in multiple areas (domain-oriented names, endpoint/history-oriented names, mixed singular/plural forms).
This slows code navigation because filenames do not consistently communicate data dimension or responsibility.
Goal: refactor `.go` filenames across the whole repository to a consistent naming model, and align declaration placement with filename responsibility, without changing runtime behavior.
## Scope
Applies to all `.go` files in the repository.
In scope:
- Rename `.go` files to consistent, responsibility-first names.
- Mechanical updates required by rename/move.
- Move declarations between files when needed so file responsibility is clear.
Out of scope:
- Any behavior or logic changes.
- Non-`.go` files.
- New feature work.
## Requirements
1. `.go` filename naming is consistent across the repository.
2. Filenames follow responsibility-first conventions:
- data-dimension names where applicable (`spot_*`, `futures_*`, etc.)
- pluralized collection-oriented files (`*_pairs.go`, `*_prices.go`)
- avoid endpoint/history-oriented naming that obscures responsibility.
3. Declarations in each file match filename responsibility.
4. No public/package behavior change.
5. Resulting PR remains reviewable by grouping changes mechanically and keeping logic untouched.
## Design
### Naming model
Use a responsibility-first naming model for all `.go` files:
- A reader should infer the primary responsibility from filename alone.
- Prefer domain/data-dimension names over transport/implementation-history names.
- Use consistent singular/plural convention based on file content (entity vs collection).
### Refactor mechanics
1. Inventory `.go` files by package and classify naming inconsistencies.
2. Define target filename map package-by-package.
3. Rename files with git-aware rename operations.
4. Move declarations when file content does not match filename responsibility.
5. Keep signatures and bodies unchanged.
6. Apply only mechanical reference/import updates required by moves.
### Execution strategy for reviewability
- Use focused commits by package or subsystem.
- Keep each commit behavior-neutral.
- Separate any necessary declaration moves from broad rename waves when this improves diff readability.
## Error handling and behavior
No new error handling paths are introduced.
Existing control flow and error behavior remain unchanged.
## Testing and verification
1. Run project tests after each major package/subsystem batch.
2. Run full project test command before PR.
3. Confirm no functional diff beyond rename/move/mechanical updates.
4. Final check: each renamed file contains declarations aligned with its responsibility.
## Risks and mitigations
- Risk: accidental behavior change while moving declarations.
- Mitigation: keep signatures/bodies unchanged and validate with tests per batch.
- Risk: review noise from repo-wide scope.
- Mitigation: package-grouped commits, strict mechanical-only edits, and explicit PR summary.
- Risk: large PR becomes hard to review.
- Mitigation: preserve commit structure and provide a clear rename map in PR description.
## Success criteria
- `.go` filenames are consistent and responsibility-first across the repo.
- Declarations in each file align with filename responsibility.
- Tests pass with no behavior regression.
- PR is understandable through structured, behavior-neutral commits.
+1 -1
View File
@@ -9,7 +9,7 @@ require (
github.com/joho/godotenv v1.5.1 github.com/joho/godotenv v1.5.1
github.com/rs/zerolog v1.32.0 github.com/rs/zerolog v1.32.0
github.com/samber/lo v1.53.0 github.com/samber/lo v1.53.0
golang.org/x/text v0.36.0 golang.org/x/text v0.37.0
gopkg.in/telebot.v3 v3.3.8 gopkg.in/telebot.v3 v3.3.8
) )
+2 -2
View File
@@ -639,8 +639,8 @@ golang.org/x/text v0.3.4/go.mod h1:5Zoc/QRtKVWzQhOtBMvqHzDpF6irO9z98xDceosuGiQ=
golang.org/x/text v0.3.5/go.mod h1:5Zoc/QRtKVWzQhOtBMvqHzDpF6irO9z98xDceosuGiQ= golang.org/x/text v0.3.5/go.mod h1:5Zoc/QRtKVWzQhOtBMvqHzDpF6irO9z98xDceosuGiQ=
golang.org/x/text v0.3.6/go.mod h1:5Zoc/QRtKVWzQhOtBMvqHzDpF6irO9z98xDceosuGiQ= golang.org/x/text v0.3.6/go.mod h1:5Zoc/QRtKVWzQhOtBMvqHzDpF6irO9z98xDceosuGiQ=
golang.org/x/text v0.3.7/go.mod h1:u+2+/6zg+i71rQMx5EYifcz6MCKuco9NR6JIITiCfzQ= golang.org/x/text v0.3.7/go.mod h1:u+2+/6zg+i71rQMx5EYifcz6MCKuco9NR6JIITiCfzQ=
golang.org/x/text v0.36.0 h1:JfKh3XmcRPqZPKevfXVpI1wXPTqbkE5f7JA92a55Yxg= golang.org/x/text v0.37.0 h1:Cqjiwd9eSg8e0QAkyCaQTNHFIIzWtidPahFWR83rTrc=
golang.org/x/text v0.36.0/go.mod h1:NIdBknypM8iqVmPiuco0Dh6P5Jcdk8lJL0CUebqK164= golang.org/x/text v0.37.0/go.mod h1:a5sjxXGs9hsn/AJVwuElvCAo9v8QYLzvavO5z2PiM38=
golang.org/x/time v0.0.0-20181108054448-85acf8d2951c/go.mod h1:tRJNPiyCQ0inRvYxbN9jk5I+vvW/OXSQhTDSoE431IQ= golang.org/x/time v0.0.0-20181108054448-85acf8d2951c/go.mod h1:tRJNPiyCQ0inRvYxbN9jk5I+vvW/OXSQhTDSoE431IQ=
golang.org/x/time v0.0.0-20190308202827-9d24e82272b4/go.mod h1:tRJNPiyCQ0inRvYxbN9jk5I+vvW/OXSQhTDSoE431IQ= golang.org/x/time v0.0.0-20190308202827-9d24e82272b4/go.mod h1:tRJNPiyCQ0inRvYxbN9jk5I+vvW/OXSQhTDSoE431IQ=
golang.org/x/time v0.0.0-20191024005414-555d28b269f0/go.mod h1:tRJNPiyCQ0inRvYxbN9jk5I+vvW/OXSQhTDSoE431IQ= golang.org/x/time v0.0.0-20191024005414-555d28b269f0/go.mod h1:tRJNPiyCQ0inRvYxbN9jk5I+vvW/OXSQhTDSoE431IQ=
+10 -3
View File
@@ -2,13 +2,20 @@ package binance
var SymbolPrefixList = []string{"1000000", "1000", "1M"} var SymbolPrefixList = []string{"1000000", "1000", "1M"}
var SymbolSuffixList = []string{"USDT", "USDC"} var SymbolSuffixList = []string{"USDT", "USDC", "FDUSD"}
var SymbolSuffixMap = map[string]string{ var SymbolSuffixMap = map[string]string{
"USDT": "", "USDT": "",
"USDC": "c", "USDC": "c",
"FDUSD": "fd",
} }
var Future2SpotSymbolMap = map[string]string{ var QuotePriority = []string{"USDT", "USDC", "FDUSD"}
"LUNA2USDT": "LUNAUSDT",
var FutureToken2SpotTokenMap = map[string]string{
"LUNA2": "LUNA",
}
var SpotToken2FutureTokenMap = map[string]string{
"LUNA": "LUNA2",
} }
+1 -1
View File
@@ -8,7 +8,7 @@ const (
var Token2StickerIdxMap = map[string]int{ var Token2StickerIdxMap = map[string]int{
"BNB": 3, "BNB": 3,
"TON": 7, "TON": 5,
} }
var Sticker2TokenMap = map[string]string{ var Sticker2TokenMap = map[string]string{
+2
View File
@@ -18,5 +18,7 @@ type IMarket interface {
// Trading pair methods // Trading pair methods
IsSpotPair(symbol string) bool IsSpotPair(symbol string) bool
IsFuturesPair(symbol string) bool IsFuturesPair(symbol string) bool
GetSpotSymbolByToken(token string) (string, bool)
GetFutureSymbolByToken(token string) (string, bool)
RefreshTradingPairCache() error RefreshTradingPairCache() error
} }
+65
View File
@@ -0,0 +1,65 @@
package market
import (
"context"
"strings"
"time"
"github.com/rs/zerolog/log"
)
func (ms *MarketData) refreshFuturePairCache() error {
ctx, cancel := context.WithTimeout(context.Background(), 15*time.Second)
defer cancel()
futuresInfo, err := ms.futuresClient.NewExchangeInfoService().Do(ctx)
if err != nil {
log.Error().Err(err).Msg("Failed to fetch futures exchange info")
return err
}
futurePairs := make(map[string]bool, len(futuresInfo.Symbols))
futureTokenCandidates := make(map[string][]string)
for _, s := range futuresInfo.Symbols {
if s.Status != "TRADING" {
continue
}
futurePairs[s.Symbol] = true
token := parseTokenFromSymbolByQuotePriority(s.Symbol)
if token == "" {
continue
}
token = futureCacheTokenKey(token)
futureTokenCandidates[token] = append(futureTokenCandidates[token], s.Symbol)
}
futureToken2Symbol := make(map[string]string, len(futureTokenCandidates))
for token, candidates := range futureTokenCandidates {
futureToken2Symbol[token] = selectCanonicalSymbolByQuotePriority(token, candidates)
}
ms.pairCacheMutex.Lock()
ms.futuresPairs = futurePairs
ms.futureToken2Symbol = futureToken2Symbol
ms.lastPairCacheUpdate = time.Now()
ms.pairCacheMutex.Unlock()
return nil
}
func futureCacheTokenKey(token string) string {
return strings.ToUpper(token)
}
func (ms *MarketData) IsFuturesPair(symbol string) bool {
ms.pairCacheMutex.RLock()
defer ms.pairCacheMutex.RUnlock()
return ms.futuresPairs[symbol]
}
func (ms *MarketData) GetFutureSymbolByToken(token string) (string, bool) {
ms.pairCacheMutex.RLock()
defer ms.pairCacheMutex.RUnlock()
sym, ok := ms.futureToken2Symbol[strings.ToUpper(token)]
return sym, ok
}
+43 -7
View File
@@ -13,6 +13,8 @@ type MarketData struct {
// Trading pair caches // Trading pair caches
spotPairs map[string]bool spotPairs map[string]bool
futuresPairs map[string]bool futuresPairs map[string]bool
spotToken2Symbol map[string]string
futureToken2Symbol map[string]string
pairCacheMutex sync.RWMutex pairCacheMutex sync.RWMutex
lastPairCacheUpdate time.Time lastPairCacheUpdate time.Time
@@ -31,25 +33,59 @@ func NewMarketData() *MarketData {
ms := &MarketData{ ms := &MarketData{
spotPairs: make(map[string]bool), spotPairs: make(map[string]bool),
futuresPairs: make(map[string]bool), futuresPairs: make(map[string]bool),
spotToken2Symbol: make(map[string]string),
futureToken2Symbol: make(map[string]string),
alphaTokens: make(map[string]AlphaTokenInfo), alphaTokens: make(map[string]AlphaTokenInfo),
spotClient: binance.NewClient("", ""), spotClient: binance.NewClient("", ""),
futuresClient: futures.NewClient("", ""), futuresClient: futures.NewClient("", ""),
} }
if err := ms.refreshTradingPairCache(); err != nil { ms.refreshAllCaches()
log.Error().Err(err).Msg("Failed initial trading pair cache load") go ms.cacheRefreshLoop()
}
go ms.pairCacheRefreshLoop()
go ms.alphaCacheRefreshLoop()
return ms return ms
} }
func (ms *MarketData) alphaCacheRefreshLoop() { func (ms *MarketData) refreshTradingPairCache() error {
ms.refreshAlphaTokenCache() if err := ms.refreshSpotPairCache(); err != nil {
return err
}
if err := ms.refreshFuturePairCache(); err != nil {
return err
}
ms.pairCacheMutex.RLock()
spotCount := len(ms.spotPairs)
futureCount := len(ms.futuresPairs)
ms.pairCacheMutex.RUnlock()
log.Info().
Int("spot", spotCount).
Int("futures", futureCount).
Msg("Trading pair cache refreshed")
return nil
}
func (ms *MarketData) cacheRefreshLoop() {
ms.refreshAllCaches()
ticker := time.NewTicker(time.Hour) ticker := time.NewTicker(time.Hour)
defer ticker.Stop() defer ticker.Stop()
for range ticker.C { for range ticker.C {
ms.refreshAllCaches()
}
}
func (ms *MarketData) refreshAllCaches() {
if err := ms.refreshSpotPairCache(); err != nil {
log.Error().Err(err).Msg("Failed spot pair refresh")
}
if err := ms.refreshFuturePairCache(); err != nil {
log.Error().Err(err).Msg("Failed futures pair refresh")
}
ms.refreshAlphaTokenCache() ms.refreshAlphaTokenCache()
} }
func (ms *MarketData) RefreshTradingPairCache() error {
return ms.refreshTradingPairCache()
} }
+41
View File
@@ -0,0 +1,41 @@
package market
import "testing"
func TestSelectCanonicalSymbolByQuotePriority(t *testing.T) {
pairs := []string{"DOGEFDUSD", "DOGEUSDC", "DOGEUSDT"}
got := selectCanonicalSymbolByQuotePriority("DOGE", pairs)
if got != "DOGEUSDT" {
t.Fatalf("expected DOGEUSDT, got %q", got)
}
}
func TestSelectCanonicalSymbolByQuotePriority_FallbackOrder(t *testing.T) {
pairs := []string{"DOGEFDUSD", "DOGEUSDC"}
got := selectCanonicalSymbolByQuotePriority("DOGE", pairs)
if got != "DOGEUSDC" {
t.Fatalf("expected DOGEUSDC, got %q", got)
}
}
func TestSelectCanonicalSymbolByQuotePriority_NoPreferredQuote(t *testing.T) {
pairs := []string{"DOGEBUSD"}
got := selectCanonicalSymbolByQuotePriority("DOGE", pairs)
if got != "DOGEBUSD" {
t.Fatalf("expected DOGEBUSD, got %q", got)
}
}
func TestFutureCacheTokenKey_PreservesRawFutureToken(t *testing.T) {
got := futureCacheTokenKey("LUNA2")
if got != "LUNA2" {
t.Fatalf("expected LUNA2, got %q", got)
}
}
func TestFutureCacheTokenKey_NoOverride(t *testing.T) {
got := futureCacheTokenKey("PEPE")
if got != "PEPE" {
t.Fatalf("expected PEPE, got %q", got)
}
}
+103
View File
@@ -0,0 +1,103 @@
package market
import (
"context"
"sort"
"strings"
"time"
"github.com/rs/zerolog/log"
"me.thuanle/bbot/internal/configs/binance"
)
func (ms *MarketData) refreshSpotPairCache() error {
ctx, cancel := context.WithTimeout(context.Background(), 15*time.Second)
defer cancel()
spotInfo, err := ms.spotClient.NewExchangeInfoService().Do(ctx)
if err != nil {
log.Error().Err(err).Msg("Failed to fetch spot exchange info")
return err
}
spotPairs := make(map[string]bool, len(spotInfo.Symbols))
spotTokenCandidates := make(map[string][]string)
for _, s := range spotInfo.Symbols {
if s.Status != "TRADING" {
continue
}
spotPairs[s.Symbol] = true
token := parseTokenFromSymbolByQuotePriority(s.Symbol)
if token == "" {
continue
}
spotTokenCandidates[token] = append(spotTokenCandidates[token], s.Symbol)
}
spotToken2Symbol := make(map[string]string, len(spotTokenCandidates))
for token, candidates := range spotTokenCandidates {
spotToken2Symbol[token] = selectCanonicalSymbolByQuotePriority(token, candidates)
}
ms.pairCacheMutex.Lock()
ms.spotPairs = spotPairs
ms.spotToken2Symbol = spotToken2Symbol
ms.lastPairCacheUpdate = time.Now()
ms.pairCacheMutex.Unlock()
return nil
}
func parseTokenFromSymbolByQuotePriority(symbol string) string {
symbol = strings.ToUpper(symbol)
for _, quote := range binance.QuotePriority {
quote = strings.ToUpper(quote)
if strings.HasSuffix(symbol, quote) {
token := strings.TrimSuffix(symbol, quote)
if token != "" {
return token
}
}
}
return ""
}
func selectCanonicalSymbolByQuotePriority(token string, candidates []string) string {
if len(candidates) == 0 {
return ""
}
if len(candidates) == 1 {
return strings.ToUpper(candidates[0])
}
token = strings.ToUpper(token)
normalized := make([]string, 0, len(candidates))
for _, c := range candidates {
normalized = append(normalized, strings.ToUpper(c))
}
for _, quote := range binance.QuotePriority {
target := token + strings.ToUpper(quote)
for _, c := range normalized {
if c == target {
return c
}
}
}
sort.Strings(normalized)
return normalized[0]
}
func (ms *MarketData) IsSpotPair(symbol string) bool {
ms.pairCacheMutex.RLock()
defer ms.pairCacheMutex.RUnlock()
return ms.spotPairs[symbol]
}
func (ms *MarketData) GetSpotSymbolByToken(token string) (string, bool) {
ms.pairCacheMutex.RLock()
defer ms.pairCacheMutex.RUnlock()
sym, ok := ms.spotToken2Symbol[strings.ToUpper(token)]
return sym, ok
}
-74
View File
@@ -1,74 +0,0 @@
package market
import (
"context"
"time"
"github.com/rs/zerolog/log"
)
func (ms *MarketData) refreshTradingPairCache() error {
ctx, cancel := context.WithTimeout(context.Background(), 15*time.Second)
defer cancel()
spotInfo, err := ms.spotClient.NewExchangeInfoService().Do(ctx)
if err != nil {
log.Error().Err(err).Msg("Failed to fetch spot exchange info")
return err
}
futuresInfo, err := ms.futuresClient.NewExchangeInfoService().Do(ctx)
if err != nil {
log.Error().Err(err).Msg("Failed to fetch futures exchange info")
return err
}
ms.pairCacheMutex.Lock()
defer ms.pairCacheMutex.Unlock()
ms.spotPairs = make(map[string]bool, len(spotInfo.Symbols))
for _, s := range spotInfo.Symbols {
if s.Status == "TRADING" {
ms.spotPairs[s.Symbol] = true
}
}
ms.futuresPairs = make(map[string]bool, len(futuresInfo.Symbols))
for _, s := range futuresInfo.Symbols {
if s.Status == "TRADING" {
ms.futuresPairs[s.Symbol] = true
}
}
ms.lastPairCacheUpdate = time.Now()
log.Info().
Int("spot", len(ms.spotPairs)).
Int("futures", len(ms.futuresPairs)).
Msg("Trading pair cache refreshed")
return nil
}
func (ms *MarketData) pairCacheRefreshLoop() {
ms.refreshTradingPairCache()
ticker := time.NewTicker(time.Hour)
defer ticker.Stop()
for range ticker.C {
ms.refreshTradingPairCache()
}
}
func (ms *MarketData) IsSpotPair(symbol string) bool {
ms.pairCacheMutex.RLock()
defer ms.pairCacheMutex.RUnlock()
return ms.spotPairs[symbol]
}
func (ms *MarketData) IsFuturesPair(symbol string) bool {
ms.pairCacheMutex.RLock()
defer ms.pairCacheMutex.RUnlock()
return ms.futuresPairs[symbol]
}
func (ms *MarketData) RefreshTradingPairCache() error {
return ms.refreshTradingPairCache()
}
+35 -38
View File
@@ -9,50 +9,54 @@ import (
) )
func Token2FutureSymbols(token string) []string { func Token2FutureSymbols(token string) []string {
var syms []string
if !stringx.IsAlphaNumeric(token) { if !stringx.IsAlphaNumeric(token) {
return syms return nil
} }
token = strings.ToUpper(token) token = strings.ToUpper(token)
if mapped, ok := data.Market.GetFutureSymbolByToken(token); ok {
for _, prefix := range checkingPrefixList { return []string{mapped}
prefix = strings.ToUpper(prefix)
s := prefix + token
if data.Market.IsFuturesPair(s) {
syms = append(syms, s)
continue
} }
for _, suffix := range binance.SymbolSuffixList { if futureToken, ok := binance.SpotToken2FutureTokenMap[token]; ok {
suffix = strings.ToUpper(suffix) if mapped, ok := data.Market.GetFutureSymbolByToken(strings.ToUpper(futureToken)); ok {
abbr := strings.ToUpper(binance.SymbolSuffixMap[suffix]) return []string{mapped}
}
sym := s + suffix
if data.Market.IsFuturesPair(sym) {
syms = append(syms, sym)
continue
} }
symAbr, found := stringx.ReplaceSuffix(s, abbr, suffix) return nil
if found && data.Market.IsFuturesPair(symAbr) {
syms = append(syms, symAbr)
continue
}
}
}
return syms
} }
func Token2SpotSymbols(token string) []string { func Token2SpotSymbols(token string) []string {
futureSymbols := Token2FutureSymbols(token) if !stringx.IsAlphaNumeric(token) {
spots := make([]string, 0, len(futureSymbols)+1) return nil
seen := make(map[string]struct{}, len(futureSymbols)+1) }
for _, futureSymbol := range futureSymbols { token = strings.ToUpper(token)
if mapped, ok := data.Market.GetSpotSymbolByToken(token); ok {
return []string{mapped}
}
return nil
}
func Token2RelatedSpotSymbols(token string) []string {
token = strings.ToUpper(token)
seen := make(map[string]struct{}, 2)
spots := make([]string, 0, 2)
for _, futureSymbol := range Token2FutureSymbols(token) {
spotSymbol := Future2SpotSymbol(futureSymbol) spotSymbol := Future2SpotSymbol(futureSymbol)
if _, ok := seen[spotSymbol]; ok {
continue
}
if data.Market.IsSpotPair(spotSymbol) {
seen[spotSymbol] = struct{}{}
spots = append(spots, spotSymbol)
}
}
for _, spotSymbol := range Token2SpotSymbols(token) {
if _, ok := seen[spotSymbol]; ok { if _, ok := seen[spotSymbol]; ok {
continue continue
} }
@@ -60,12 +64,5 @@ func Token2SpotSymbols(token string) []string {
spots = append(spots, spotSymbol) spots = append(spots, spotSymbol)
} }
spotOnly := strings.ToUpper(token) + "USDT"
if data.Market.IsSpotPair(spotOnly) {
if _, ok := seen[spotOnly]; !ok {
spots = append(spots, spotOnly)
}
}
return spots return spots
} }
+139 -29
View File
@@ -1,13 +1,16 @@
package binancex package binancex
import ( import (
"strings"
"testing" "testing"
"me.thuanle/bbot/internal/configs/binance"
"me.thuanle/bbot/internal/data" "me.thuanle/bbot/internal/data"
"me.thuanle/bbot/internal/data/market" "me.thuanle/bbot/internal/data/market"
) )
type resolverMarketStub struct { type resolverMarketStub struct {
alphaTokens map[string]bool
spotPairs map[string]bool spotPairs map[string]bool
futuresPairs map[string]bool futuresPairs map[string]bool
} }
@@ -21,69 +24,176 @@ func (m *resolverMarketStub) GetAllPremiumIndex() (map[string]market.PremiumInde
func (m *resolverMarketStub) GetAllFundRate() (map[string]float64, map[string]int64) { return nil, nil } func (m *resolverMarketStub) GetAllFundRate() (map[string]float64, map[string]int64) { return nil, nil }
func (m *resolverMarketStub) GetSpotPrice(symbol string) (float64, bool) { return 0, false } func (m *resolverMarketStub) GetSpotPrice(symbol string) (float64, bool) { return 0, false }
func (m *resolverMarketStub) GetMarginInterestRates() map[string]float64 { return nil } func (m *resolverMarketStub) GetMarginInterestRates() map[string]float64 { return nil }
func (m *resolverMarketStub) IsAlphaToken(symbol string) bool { return false } func (m *resolverMarketStub) IsAlphaToken(symbol string) bool { return m.alphaTokens[symbol] }
func (m *resolverMarketStub) GetAlphaToken(symbol string) (market.AlphaTokenInfo, bool) { func (m *resolverMarketStub) GetAlphaToken(symbol string) (market.AlphaTokenInfo, bool) {
return market.AlphaTokenInfo{}, false return market.AlphaTokenInfo{}, false
} }
func (m *resolverMarketStub) GetAlphaPrice(symbol string) (float64, bool) { return 0, false } func (m *resolverMarketStub) GetAlphaPrice(symbol string) (float64, bool) { return 0, false }
func (m *resolverMarketStub) IsSpotPair(symbol string) bool { return m.spotPairs[symbol] } func (m *resolverMarketStub) IsSpotPair(symbol string) bool { return m.spotPairs[symbol] }
func (m *resolverMarketStub) IsFuturesPair(symbol string) bool { return m.futuresPairs[symbol] } func (m *resolverMarketStub) IsFuturesPair(symbol string) bool { return m.futuresPairs[symbol] }
func (m *resolverMarketStub) GetSpotSymbolByToken(token string) (string, bool) {
token = strings.ToUpper(token)
for sym := range m.spotPairs {
if strings.ToUpper(Symbol2Token(sym)) == token {
return sym, true
}
}
return "", false
}
func (m *resolverMarketStub) GetFutureSymbolByToken(token string) (string, bool) {
token = strings.ToUpper(token)
for sym := range m.futuresPairs {
if strings.ToUpper(Symbol2Token(sym)) == token {
return sym, true
}
}
return "", false
}
func (m *resolverMarketStub) RefreshTradingPairCache() error { return nil } func (m *resolverMarketStub) RefreshTradingPairCache() error { return nil }
func TestToken2FutureSymbols_ResolvesPrefixAndSuffix(t *testing.T) { func withResolverMarketStub(t *testing.T, marketStub *resolverMarketStub) {
t.Helper()
orig := data.Market orig := data.Market
defer func() { data.Market = orig }() data.Market = marketStub
t.Cleanup(func() { data.Market = orig })
}
data.Market = &resolverMarketStub{ func TestToken2FutureSymbols_ReturnsCanonicalFutureSymbol(t *testing.T) {
withResolverMarketStub(t, &resolverMarketStub{
futuresPairs: map[string]bool{ futuresPairs: map[string]bool{
"1000PEPEUSDT": true, "1000PEPEUSDT": true,
"1000PEPEUSDC": true, "1000PEPEUSDC": true,
}, },
} })
syms := Token2FutureSymbols("pepe") syms := Token2FutureSymbols("pepe")
if len(syms) == 0 { if len(syms) != 1 || syms[0] != "1000PEPEUSDT" {
t.Fatalf("expected future symbols for PEPE") t.Fatalf("expected canonical [1000PEPEUSDT], got %+v", syms)
}
foundUSDT := false
foundUSDC := false
for _, sym := range syms {
if sym == "1000PEPEUSDT" {
foundUSDT = true
}
if sym == "1000PEPEUSDC" {
foundUSDC = true
} }
} }
if !foundUSDT || !foundUSDC { func TestToken2FutureSymbols_UsesCanonicalQuotePriority(t *testing.T) {
t.Fatalf("expected both 1000PEPEUSDT and 1000PEPEUSDC, got %+v", syms) withResolverMarketStub(t, &resolverMarketStub{
futuresPairs: map[string]bool{
"1000PEPEUSDT": true,
"1000PEPEUSDC": true,
"PEPEUSDT": true,
"PEPEUSDC": true,
},
})
syms := Token2FutureSymbols("pepe")
if len(syms) != 1 || syms[0] != "1000PEPEUSDT" {
t.Fatalf("expected canonical [1000PEPEUSDT], got %+v", syms)
} }
} }
func TestToken2SpotSymbols_AppliesExplicitRemap(t *testing.T) { func TestToken2FutureSymbols_ResolvesUSDCAbbreviation(t *testing.T) {
orig := data.Market withResolverMarketStub(t, &resolverMarketStub{
defer func() { data.Market = orig }() futuresPairs: map[string]bool{"PEPEUSDC": true},
})
data.Market = &resolverMarketStub{ syms := Token2FutureSymbols("pepec")
if len(syms) != 1 || syms[0] != "PEPEUSDC" {
t.Fatalf("expected [PEPEUSDC], got %+v", syms)
}
}
func TestSymbolSuffixListMatchesSymbolSuffixMap(t *testing.T) {
seen := make(map[string]struct{}, len(binance.SymbolSuffixList))
for _, suffix := range binance.SymbolSuffixList {
if _, ok := binance.SymbolSuffixMap[suffix]; !ok {
t.Fatalf("SymbolSuffixList contains %q missing from SymbolSuffixMap", suffix)
}
seen[suffix] = struct{}{}
}
for suffix := range binance.SymbolSuffixMap {
if _, ok := seen[suffix]; !ok {
t.Fatalf("SymbolSuffixMap contains %q missing from SymbolSuffixList", suffix)
}
}
}
func TestIsToken(t *testing.T) {
tests := []struct {
name string
input string
marketStub *resolverMarketStub
want bool
}{
{
name: "futures token resolution success",
input: "pepe",
marketStub: &resolverMarketStub{
futuresPairs: map[string]bool{"1000PEPEUSDT": true},
},
want: true,
},
{
name: "alpha token fallback",
input: "alpha",
marketStub: &resolverMarketStub{
alphaTokens: map[string]bool{"ALPHA": true},
},
want: true,
},
{
name: "spot only token fallback",
input: "abc",
marketStub: &resolverMarketStub{
spotPairs: map[string]bool{"ABCUSDT": true},
},
want: true,
},
{
name: "non alphanumeric input",
input: "bad!",
marketStub: &resolverMarketStub{},
want: false,
},
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
withResolverMarketStub(t, tt.marketStub)
got := IsToken(tt.input)
if got != tt.want {
t.Fatalf("expected %v, got %v", tt.want, got)
}
})
}
}
func TestToken2SpotSymbols_DoesNotDependOnFutureMappings(t *testing.T) {
withResolverMarketStub(t, &resolverMarketStub{
futuresPairs: map[string]bool{"LUNA2USDT": true}, futuresPairs: map[string]bool{"LUNA2USDT": true},
spotPairs: map[string]bool{"LUNAUSDT": true}, spotPairs: map[string]bool{"LUNAUSDT": true},
} })
spots := Token2SpotSymbols("luna2") spots := Token2SpotSymbols("luna2")
if len(spots) != 0 {
t.Fatalf("expected no direct spot symbols for LUNA2, got %+v", spots)
}
}
func TestToken2RelatedSpotSymbols_AppliesExplicitRemap(t *testing.T) {
withResolverMarketStub(t, &resolverMarketStub{
futuresPairs: map[string]bool{"LUNA2USDT": true},
spotPairs: map[string]bool{"LUNAUSDT": true},
})
spots := Token2RelatedSpotSymbols("luna2")
if len(spots) != 1 || spots[0] != "LUNAUSDT" { if len(spots) != 1 || spots[0] != "LUNAUSDT" {
t.Fatalf("expected [LUNAUSDT], got %+v", spots) t.Fatalf("expected [LUNAUSDT], got %+v", spots)
} }
} }
func TestToken2SpotSymbols_SpotOnlyFallback(t *testing.T) { func TestToken2SpotSymbols_SpotOnlyFallback(t *testing.T) {
orig := data.Market withResolverMarketStub(t, &resolverMarketStub{
defer func() { data.Market = orig }()
data.Market = &resolverMarketStub{
spotPairs: map[string]bool{"ABCUSDT": true}, spotPairs: map[string]bool{"ABCUSDT": true},
} })
spots := Token2SpotSymbols("abc") spots := Token2SpotSymbols("abc")
if len(spots) != 1 || spots[0] != "ABCUSDT" { if len(spots) != 1 || spots[0] != "ABCUSDT" {
+7 -6
View File
@@ -30,12 +30,13 @@ var (
) )
func IsToken(s string) bool { func IsToken(s string) bool {
// First check regular symbols
if len(Token2FutureSymbols(s)) > 0 { if len(Token2FutureSymbols(s)) > 0 {
return true return true
} }
if len(Token2SpotSymbols(s)) > 0 {
return true
}
// Then check Alpha tokens
s = strings.ToUpper(s) s = strings.ToUpper(s)
return data.Market.IsAlphaToken(s) return data.Market.IsAlphaToken(s)
} }
@@ -50,9 +51,9 @@ func Future2SpotSymbol(sym string) string {
} }
} }
spotSym, ok := binance.Future2SpotSymbolMap[sym] token := Symbol2Token(sym)
if !ok { if mapped, ok := binance.FutureToken2SpotTokenMap[token]; ok {
return sym token = strings.ToUpper(mapped)
} }
return spotSym return token + "USDT"
} }
+1 -1
View File
@@ -87,7 +87,7 @@ func collectRichTokenData(token string) buildRichTokenMessageArgs {
} }
} }
spotSymbols := binancex.Token2SpotSymbols(token) spotSymbols := binancex.Token2RelatedSpotSymbols(token)
for _, spotSymbol := range spotSymbols { for _, spotSymbol := range spotSymbols {
if sp, ok := data.Market.GetSpotPrice(spotSymbol); ok { if sp, ok := data.Market.GetSpotPrice(spotSymbol); ok {
a.HasSpot = true a.HasSpot = true
@@ -1,10 +1,12 @@
package commands package commands
import ( import (
"strings"
"testing" "testing"
"me.thuanle/bbot/internal/data" "me.thuanle/bbot/internal/data"
"me.thuanle/bbot/internal/data/market" "me.thuanle/bbot/internal/data/market"
"me.thuanle/bbot/internal/helper/binancex"
) )
func TestBuildRichTokenMessageInput_AllSources(t *testing.T) { func TestBuildRichTokenMessageInput_AllSources(t *testing.T) {
@@ -88,6 +90,24 @@ func (m *marketStub) GetAlphaPrice(symbol string) (float64, bool) {
} }
func (m *marketStub) IsSpotPair(symbol string) bool { return m.spotPairs[symbol] } func (m *marketStub) IsSpotPair(symbol string) bool { return m.spotPairs[symbol] }
func (m *marketStub) IsFuturesPair(symbol string) bool { return m.futuresPairs[symbol] } func (m *marketStub) IsFuturesPair(symbol string) bool { return m.futuresPairs[symbol] }
func (m *marketStub) GetSpotSymbolByToken(token string) (string, bool) {
token = strings.ToUpper(token)
for symbol := range m.spotPairs {
if binancex.Symbol2Token(symbol) == token {
return symbol, true
}
}
return "", false
}
func (m *marketStub) GetFutureSymbolByToken(token string) (string, bool) {
token = strings.ToUpper(token)
for symbol := range m.futuresPairs {
if binancex.Symbol2Token(symbol) == token {
return symbol, true
}
}
return "", false
}
func (m *marketStub) RefreshTradingPairCache() error { return nil } func (m *marketStub) RefreshTradingPairCache() error { return nil }
func TestCollectRichTokenData_SpotOnlyReachable(t *testing.T) { func TestCollectRichTokenData_SpotOnlyReachable(t *testing.T) {
-1
View File
@@ -1 +0,0 @@
go run cmd/tele/main.go ─╯