diff --git a/.codex/skills/review-pr/SKILL.md b/.codex/skills/review-pr/SKILL.md index 4584b47..6aa98f7 100644 --- a/.codex/skills/review-pr/SKILL.md +++ b/.codex/skills/review-pr/SKILL.md @@ -25,10 +25,12 @@ description: Phase 2 skill. Use when a PR is created or updated. Review PR again - Identify the linked issue from PR body (`Fixes #` or `Closes #`). - Read issue comments, find the **Final Requirements** comment: `mcp__gitea__.issue_read` (`method: "get_comments"`). - Read existing reviews: `mcp__gitea__.pull_request_read` (`method: "get_reviews"`). + - Read PR discussion comments: `mcp__gitea__.issue_read` (`method: "get_comments"`), using the PR number as the index. - If PR is already merged or closed, say so and stop. 2. **Read review history** (for re-reviews) - Get review comments: `mcp__gitea__.pull_request_read` (`method: "get_review_comments"`). + - Treat reviews, inline review comments, and PR discussion comments as separate context sources. - If author addressed feedback in a follow-up commit, focus on new commits but still sanity-check the full diff. 3. **Get the diff** @@ -102,6 +104,7 @@ Validation: - Do NOT edit code on the PR. - FAIL if PR contains unrelated changes or scope creep. - Post review proactively if verdict is clear. +- Do not post a verdict until PR discussion comments have been checked. - Mention validation commands you actually ran. - No bracketed author/tool tags. - Accept `docs/adr/**` when it records a direct, durable decision tied to the issue scope. diff --git a/AGENT.md b/AGENT.md index 9c9dc98..225feaa 100644 --- a/AGENT.md +++ b/AGENT.md @@ -70,7 +70,7 @@ All work starts from a Gitea issue. Two phases, each with a dedicated role: **Constraint:** Reviewer must NOT edit code on the PR. 1. Re-read the original issue — verify PR addresses the locked requirement. -2. Read PR diff and discussion history. +2. Read PR diff, review history, and PR discussion comments. 3. Validate in worktree if needed (`.worktrees/pr-`, run `go test`, `go vet`, `gofmt`). 4. Check for scope creep — FAIL if PR contains unrelated changes or refactoring. 5. Write verdict — start with **PASS** or **FAIL**.