update DoD
This commit is contained in:
@@ -33,6 +33,8 @@ description: Phase 2 skill. Use when issue scope is locked by Product Owner (Pha
|
||||
3. **Write plan and post on issue**
|
||||
- List implementation steps with verification criteria.
|
||||
- List files to change.
|
||||
- State whether `README.md` or `.env.example` must change.
|
||||
- State whether an ADR is required or not required.
|
||||
- Flag risks or tradeoffs.
|
||||
- Post plan as comment: `mcp__gitea__.issue_write` (`method: "add_comment"`).
|
||||
- **Wait for "Approved" before coding.** Stop here.
|
||||
@@ -48,18 +50,32 @@ description: Phase 2 skill. Use when issue scope is locked by Product Owner (Pha
|
||||
git worktree add .worktrees/<branch-name> main
|
||||
```
|
||||
- Implement following the plan (surgical changes only).
|
||||
- Update `README.md` and `.env.example` when config, endpoint, or runtime behavior changes.
|
||||
- If the change introduces a durable behavior, contract, architecture, or workflow decision, create/update `docs/adr/**`.
|
||||
- Run validation:
|
||||
```
|
||||
gofmt -l .
|
||||
go vet ./...
|
||||
go test ./...
|
||||
go vet ./...
|
||||
staticcheck ./...
|
||||
```
|
||||
- Post an implementation summary comment on the issue with sections:
|
||||
- `Summary`
|
||||
- `Changes`
|
||||
- `Test Plan`
|
||||
- `Refactor`
|
||||
- `Docs/ADR`
|
||||
- `Risks/Follow-ups`
|
||||
|
||||
5. **Create PR**
|
||||
- Use `mcp__gitea__.pull_request_write` (`method: "create"`).
|
||||
- PR body must include:
|
||||
- Summary of changes
|
||||
- Test evidence (exact commands and output)
|
||||
- `Summary`
|
||||
- `Changes`
|
||||
- `Test Plan` with exact commands and output
|
||||
- `Refactor`
|
||||
- `Docs/ADR`
|
||||
- `Risks/Follow-ups`
|
||||
- `Fixes #<issue-id>`
|
||||
- Add reviewer.
|
||||
|
||||
@@ -76,6 +92,8 @@ description: Phase 2 skill. Use when issue scope is locked by Product Owner (Pha
|
||||
- Use Gitea MCP tools for all issue/PR operations.
|
||||
- Preserve existing assignees when adding yourself unless the user explicitly asks to replace them.
|
||||
- Never edit remote files directly — always work on local branch.
|
||||
- Satisfy the repo Definition of Done before claiming completion.
|
||||
- Missing required tests, docs, `.env.example` updates, or ADRs is a quality failure unless explicitly justified in both the issue comment and PR body.
|
||||
- Never claim completion without fresh verification output.
|
||||
- Keep changes strictly scoped to the approved plan.
|
||||
- If the change needs durable documentation, create/update `docs/adr/**`. Do not commit `docs/superpowers/**` planning artifacts.
|
||||
|
||||
@@ -47,8 +47,9 @@ description: Phase 2 skill. Use when a PR is created or updated. Review PR again
|
||||
- Run checks:
|
||||
```
|
||||
gofmt -l .
|
||||
go vet ./...
|
||||
go test ./...
|
||||
go vet ./...
|
||||
staticcheck ./...
|
||||
```
|
||||
- Remove worktree when done:
|
||||
```
|
||||
@@ -57,6 +58,11 @@ description: Phase 2 skill. Use when a PR is created or updated. Review PR again
|
||||
|
||||
5. **Evaluate**
|
||||
- Does PR address **all** Final Requirements from the issue?
|
||||
- Does PR satisfy the repo Definition of Done?
|
||||
- relevant tests for behavior/config changes
|
||||
- required `README.md` / `.env.example` updates
|
||||
- ADR present when the change locks in a durable decision
|
||||
- required implementation evidence exists on the issue and in the PR body
|
||||
- Does PR contain unrelated changes or refactoring? → FAIL immediately.
|
||||
- Code correctness, style, test coverage.
|
||||
|
||||
@@ -85,6 +91,7 @@ Validation:
|
||||
- gofmt -l .: OK
|
||||
- go vet ./...: OK
|
||||
- go test ./...: OK
|
||||
- staticcheck ./...: OK
|
||||
|
||||
Non-blocking:
|
||||
- <optional note>
|
||||
@@ -106,6 +113,7 @@ Validation:
|
||||
- Do not add yourself as reviewer twice; check requested reviewers and existing reviews first.
|
||||
- Do NOT edit code on the PR.
|
||||
- FAIL if PR contains unrelated changes or scope creep.
|
||||
- FAIL if the PR misses required DoD evidence, docs, or ADR work for the accepted change.
|
||||
- Post review proactively if verdict is clear.
|
||||
- Do not post a verdict until PR discussion comments have been checked.
|
||||
- Mention validation commands you actually ran.
|
||||
|
||||
@@ -27,6 +27,8 @@ description: Phase 1 skill. Use when a Gitea issue is created or updated and nee
|
||||
- Is the problem statement clear?
|
||||
- Is the scope well-defined or too broad?
|
||||
- Is it technically feasible?
|
||||
- What acceptance criteria will prove the change is done?
|
||||
- Will the change require docs updates or a durable ADR?
|
||||
- If needed, read relevant code: `mcp__gitea__.get_file_contents`.
|
||||
|
||||
3. **Decide**
|
||||
@@ -34,8 +36,9 @@ description: Phase 1 skill. Use when a Gitea issue is created or updated and nee
|
||||
- Post clarifying questions: `mcp__gitea__.issue_write` (`method: "add_comment"`).
|
||||
- Stop. Wait for user to respond, then re-run this skill.
|
||||
- **Clear and feasible:**
|
||||
- Post Final Requirements (see format below).
|
||||
- If the change likely needs a durable ADR, add a note: "ADR recommended: this change locks in a behavior/contract that future work must preserve."
|
||||
- Post Final Requirements (see format below) with specific acceptance criteria.
|
||||
- State whether docs updates are expected.
|
||||
- State whether an ADR is required, recommended, or not needed.
|
||||
- This locks the scope and signals Phase 2 can begin.
|
||||
|
||||
## Final Requirements format
|
||||
@@ -55,11 +58,18 @@ description: Phase 1 skill. Use when a Gitea issue is created or updated and nee
|
||||
**Acceptance criteria:**
|
||||
- <verifiable check 1>
|
||||
- <verifiable check 2>
|
||||
|
||||
**Documentation impact:**
|
||||
- <README.md / .env.example updates required or not required>
|
||||
|
||||
**ADR:**
|
||||
- <required / recommended / not needed, with one-line reason>
|
||||
```
|
||||
|
||||
## Rules
|
||||
- Use Gitea MCP tools for all operations.
|
||||
- Do NOT write code, create branches, or create PRs.
|
||||
- Make acceptance criteria specific enough that Dev and Reviewer can verify Definition of Done without guessing.
|
||||
- Do NOT proceed to Phase 2 — that is a separate skill.
|
||||
|
||||
## Next skill
|
||||
|
||||
Reference in New Issue
Block a user