update DoD

This commit is contained in:
2026-04-29 00:27:30 +07:00
parent 0d9230bd5f
commit c616fcf037
4 changed files with 79 additions and 14 deletions
+9 -1
View File
@@ -47,8 +47,9 @@ description: Phase 2 skill. Use when a PR is created or updated. Review PR again
- Run checks:
```
gofmt -l .
go vet ./...
go test ./...
go vet ./...
staticcheck ./...
```
- Remove worktree when done:
```
@@ -57,6 +58,11 @@ description: Phase 2 skill. Use when a PR is created or updated. Review PR again
5. **Evaluate**
- Does PR address **all** Final Requirements from the issue?
- Does PR satisfy the repo Definition of Done?
- relevant tests for behavior/config changes
- required `README.md` / `.env.example` updates
- ADR present when the change locks in a durable decision
- required implementation evidence exists on the issue and in the PR body
- Does PR contain unrelated changes or refactoring? → FAIL immediately.
- Code correctness, style, test coverage.
@@ -85,6 +91,7 @@ Validation:
- gofmt -l .: OK
- go vet ./...: OK
- go test ./...: OK
- staticcheck ./...: OK
Non-blocking:
- <optional note>
@@ -106,6 +113,7 @@ Validation:
- Do not add yourself as reviewer twice; check requested reviewers and existing reviews first.
- Do NOT edit code on the PR.
- FAIL if PR contains unrelated changes or scope creep.
- FAIL if the PR misses required DoD evidence, docs, or ADR work for the accepted change.
- Post review proactively if verdict is clear.
- Do not post a verdict until PR discussion comments have been checked.
- Mention validation commands you actually ran.