thuanle

thuanle merged pull request public/crypto-price-bot#15

2026-04-26 16:19:28 +07:00

Rewrite price lookup from WebSocket to REST API

thuanle commented on pull request public/crypto-price-bot#15

2026-04-26 16:19:03 +07:00

Rewrite price lookup from WebSocket to REST API

PASS

Reviewed latest update in commit 914beea.

The previously reported blocking issues are fixed:

/refresh admin guard is now fail-closed.
Initial trading-pair cache load is now…

thuanle commented on pull request public/crypto-price-bot#15

2026-04-26 16:03:35 +07:00

Rewrite price lookup from WebSocket to REST API

Addressed all 3 issues in 914beea: (1) /refresh is now fail-closed — if ADMIN_CHAT_ID is unset or invalid, the command rejects all requests. (2) Initial pair cache fill is synchronous in…

thuanle pushed to feat/rest-price-lookup at public/crypto-price-bot

2026-04-26 16:03:24 +07:00

914beea5ce Address PR #15 round 2: fail-closed admin guard, sync init, error reporting

thuanle commented on pull request public/crypto-price-bot#15

2026-04-26 15:57:46 +07:00

Rewrite price lookup from WebSocket to REST API

FAIL

internal/services/tele/commands/market.go:26-28: /refresh admin guard is fail-open. If ADMIN_CHAT_ID is unset or invalid, ParseInt returns 0 and any user can call /refresh.

2.…

thuanle commented on pull request public/crypto-price-bot#15

2026-04-26 15:46:17 +07:00

Rewrite price lookup from WebSocket to REST API

Thanks for the review. Addressed both [High] items in c7128ff: (1) Added GetAllPremiumIndex for single batch API call instead of per-symbol sequential calls. (2) Added ADMIN_CHAT_ID env check to…

thuanle pushed to feat/rest-price-lookup at public/crypto-price-bot

2026-04-26 15:40:08 +07:00

c7128ff516 Address PR #15 review: batch API calls and admin-guard /refresh

thuanle commented on pull request public/crypto-price-bot#15

2026-04-26 15:36:42 +07:00

Rewrite price lookup from WebSocket to REST API

Request changes.

[High] /p đang thực hiện nhiều REST call tuần tự cho từng symbol. Binance futures premium index API hỗ trợ lấy nhiều pair trong một lần gọi (không truyền…

thuanle created pull request public/crypto-price-bot#16

2026-04-26 15:14:49 +07:00

Remove ETH special portfolio tracking

thuanle created branch chore/remove-eth-special-case in public/crypto-price-bot

2026-04-26 15:14:44 +07:00

thuanle pushed to chore/remove-eth-special-case at public/crypto-price-bot

2026-04-26 15:14:44 +07:00

59da49c17f Remove ETH special portfolio tracking

thuanle created pull request public/crypto-price-bot#15

2026-04-26 15:14:29 +07:00

Rewrite price lookup from WebSocket to REST API

thuanle created branch feat/rest-price-lookup in public/crypto-price-bot

2026-04-26 15:14:15 +07:00

thuanle pushed to feat/rest-price-lookup at public/crypto-price-bot

2026-04-26 15:14:15 +07:00

9c39423315 Rewrite price lookup from WebSocket to REST API

thuanle closed pull request public/crypto-price-bot#8

2026-04-25 02:00:27 +07:00

Update module github.com/adshao/go-binance/v2 to v2.8.11

thuanle closed pull request public/crypto-price-bot#2

2026-04-25 02:00:27 +07:00

Update golang Docker tag to v1.26

thuanle closed pull request public/crypto-price-bot#11

2026-04-25 02:00:26 +07:00

Update module golang.org/x/text to v0.36.0

thuanle closed pull request public/crypto-price-bot#9

2026-04-25 02:00:26 +07:00

Update module github.com/samber/lo to v1.53.0

thuanle closed pull request public/crypto-price-bot#12

2026-04-25 02:00:25 +07:00

Update module gopkg.in/telebot.v3 to v3.3.8

thuanle pushed to main at public/crypto-price-bot

2026-04-25 01:58:52 +07:00

c5c1cdf0d5 Add hourly Alpha token cache refresh