thuanle
0 Followers · 0 Following
  • Joined on 2024-10-11
Repositories
2
 Projects Packages Public Activity Starred Repositories
1
thuanle commented on issue public/crypto-price-bot#18 2026-04-26 19:17:26 +07:00
Rich token message handler cannot reach spot-only fallback

[claudecode gpt-5.3-codex]

Summary

Issue này đã được xử lý qua các PR đã merge.

Changes mapped to issue

  • PR #19: tách độc lập các lookup spot/future/alpha trong command handler,…
thuanle closed issue public/crypto-price-bot#18 2026-04-26 19:17:26 +07:00
Rich token message handler cannot reach spot-only fallback
thuanle deleted branch feat/parallel-price-lookup-v2 from public/crypto-price-bot 2026-04-26 19:15:58 +07:00
thuanle pushed to feat/token-message-rich at public/crypto-price-bot 2026-04-26 19:15:55 +07:00
391169761a Merge pull request 'perf: parallelize token source price requests' (#20) from feat/parallel-price-lookup-v2 into feat/token-message-rich
a54ec0dbb7 Merge branch 'feat/token-message-rich' into feat/parallel-price-lookup-v2
a36eb7aad0 perf: run token price source lookups in parallel
Compare 3 commits »
thuanle merged pull request public/crypto-price-bot#20 2026-04-26 19:15:53 +07:00
perf: parallelize token source price requests
thuanle commented on pull request public/crypto-price-bot#20 2026-04-26 19:15:13 +07:00
perf: parallelize token source price requests

[codex] review results for PR #20.

PASS

No blocking issues found in the latest update.

Validation:

  • go test ./internal/services/tele/commands -run RunsLookupsConcurrently -v -count=1
  • `go…
thuanle pushed to feat/parallel-price-lookup-v2 at public/crypto-price-bot 2026-04-26 19:00:47 +07:00
a54ec0dbb7 Merge branch 'feat/token-message-rich' into feat/parallel-price-lookup-v2
a4644f5982 Merge branch 'main' into feat/token-message-rich
194a235065 docs: document required environment variables
c841ca4421 Merge pull request 'Add rich unified token price message' (#17) from feat/token-message-rich into main
Compare 4 commits »
thuanle merged pull request public/crypto-price-bot#19 2026-04-26 18:51:18 +07:00
fix: independent token source lookups
thuanle pushed to main at public/crypto-price-bot 2026-04-26 18:51:18 +07:00
1486681ef9 Merge pull request 'fix: independent token source lookups' (#19) from feat/token-message-rich into main
a4644f5982 Merge branch 'main' into feat/token-message-rich
82b0f2f1a8 feat: fetch alpha price by symbol ticker
6e8a2e8f68 fix: decouple token spot/future/alpha lookups
Compare 4 commits »
thuanle commented on pull request public/crypto-price-bot#19 2026-04-26 18:47:49 +07:00
fix: independent token source lookups

[codex] scope clarification for PR #19.

The concern from my previous review comment is about spot/future symbol resolution only. It is not about the new Alpha lookup itself.

More specifically,…

thuanle opened issue public/crypto-price-bot#21 2026-04-26 18:43:46 +07:00
Token collector bypasses existing spot/future symbol resolution rules
thuanle pushed to feat/token-message-rich at public/crypto-price-bot 2026-04-26 18:39:54 +07:00
a4644f5982 Merge branch 'main' into feat/token-message-rich
194a235065 docs: document required environment variables
c841ca4421 Merge pull request 'Add rich unified token price message' (#17) from feat/token-message-rich into main
Compare 3 commits »
thuanle commented on pull request public/crypto-price-bot#19 2026-04-26 18:37:38 +07:00
fix: independent token source lookups

Codex review results for PR #19.

FAIL

  1. [High] collectRichTokenData regresses existing symbol resolution by hardcoding both lookups to token + "USDT" in `internal/services/tele/commands/toke…
thuanle created pull request public/crypto-price-bot#20 2026-04-26 18:31:09 +07:00
perf: parallelize token source price requests
thuanle created branch feat/parallel-price-lookup-v2 in public/crypto-price-bot 2026-04-26 18:26:40 +07:00
thuanle pushed to feat/parallel-price-lookup-v2 at public/crypto-price-bot 2026-04-26 18:26:40 +07:00
a36eb7aad0 perf: run token price source lookups in parallel
thuanle pushed to feat/token-message-rich at public/crypto-price-bot 2026-04-26 18:22:57 +07:00
82b0f2f1a8 feat: fetch alpha price by symbol ticker
thuanle created pull request public/crypto-price-bot#19 2026-04-26 18:13:41 +07:00
fix: independent token source lookups
thuanle created branch feat/token-message-rich in public/crypto-price-bot 2026-04-26 18:13:17 +07:00
thuanle pushed to feat/token-message-rich at public/crypto-price-bot 2026-04-26 18:13:17 +07:00
6e8a2e8f68 fix: decouple token spot/future/alpha lookups