codex
0 Followers · 0 Following
  • Joined on 2026-04-26
Repositories Projects Packages Public Activity Starred Repositories
codex commented on issue public/crypto-price-bot#26 2026-04-27 05:07:42 +07:00
Refactor market package filenames for consistent data-dimension naming

Mình đã rà lại code hiện tại sau PR canonical maps.

Issue này vẫn hợp lý, nhưng nên chỉnh scope một chút: trading_pairs.go hiện không chỉ là “trading pairs” nữa mà đang chứa…

codex commented on pull request public/crypto-price-bot#25 2026-04-27 04:59:24 +07:00
fix: recognize spot-only tokens in IsToken

PASS

No blocking issues found in the latest update. The futures cache now preserves raw futures-token identity, and spot-to-future alias lookup is explicit via SpotToken2FutureTokenMap.

Validat…

codex commented on pull request public/crypto-price-bot#25 2026-04-27 04:50:27 +07:00
fix: recognize spot-only tokens in IsToken

[codex] follow-up review for PR #25.

FAIL

  1. [High] The canonical futures cache is currently normalized in the wrong direction. In refreshFuturePairCache, LUNA2USDT is parsed as token…
codex commented on pull request public/crypto-price-bot#25 2026-04-27 04:06:23 +07:00
fix: recognize spot-only tokens in IsToken

[codex] review results for PR #25.

FAIL

  1. [Medium] internal/helper/binancex/symbol.go: IsToken now relies on Token2SpotSymbols, but Token2SpotSymbols itself calls Token2FutureSymbols.…
codex commented on pull request public/crypto-price-bot#23 2026-04-27 03:47:59 +07:00
Refactor Binance symbol resolver

[codex] review results for PR #23.

PASS

No blocking issues found in the latest update. The previous requested test coverage has been added, and the stale request-changes review is addressed by…

codex opened issue public/crypto-price-bot#24 2026-04-27 03:42:50 +07:00
IsToken không nhận diện spot-only token
codex created pull request public/crypto-price-bot#23 2026-04-27 03:32:16 +07:00
Refactor Binance symbol resolver
codex commented on pull request public/crypto-price-bot#22 2026-04-26 21:12:00 +07:00
fix: resolve shared symbol mapping for token command

[codex] review results for PR #22.

PASS

No blocking issues found in the latest update at head e4922eb.

Validation:

  • git fetch origin
  • go test ./...
  • go vet ./...

Non-blocking…

codex commented on pull request public/crypto-price-bot#22 2026-04-26 20:59:28 +07:00
fix: resolve shared symbol mapping for token command

[codex] review results for PR #22.

FAIL

  1. [High] internal/helper/binancex/resolver_test.go does not build. resolverMarketStub is assigned to data.Market, but it does not implement the…
codex commented on pull request public/crypto-price-bot#22 2026-04-26 20:42:24 +07:00
fix: resolve shared symbol mapping for token command

[codex] note for PR #22.

PR này đang conflict vì bot cũ dựng branch trên base đã stale trong khi main vừa thay đổi cùng khu vực code qua #19. Đây là lỗi quy trình có thể tránh…