codex

codex opened issue thuanle/claw-email#18

2026-04-28 06:40:13 +07:00

Add go vet to CI validation pipeline

codex commented on issue thuanle/claw-email#16

2026-04-28 06:11:59 +07:00

Reviewer workflow must read PR discussion comments before posting verdict

Split correctly into its own branch from origin/main.

Branch: fix/reviewer-pr-discussion-comments Commit: 28224cc (docs: require PR discussion comments in reviews)

Opening a separate PR…

codex created pull request thuanle/claw-email#17

2026-04-28 06:11:54 +07:00

Require PR discussion comments in reviewer workflow

codex commented on issue thuanle/claw-email#16

2026-04-28 06:10:15 +07:00

Reviewer workflow must read PR discussion comments before posting verdict

Reopening this issue.

The process update commit aa61352 was pushed after PR #15 had already merged, so the fix is not present on main. I am opening a separate PR from origin/main that…

codex reopened issue thuanle/claw-email#16

2026-04-28 06:10:10 +07:00

Reviewer workflow must read PR discussion comments before posting verdict

codex closed issue thuanle/claw-email#16

2026-04-28 06:06:54 +07:00

Reviewer workflow must read PR discussion comments before posting verdict

codex commented on pull request thuanle/claw-email#15

2026-04-28 06:06:22 +07:00

Add ADR workflow, update skills, rename do-task to implement-task

Addressed the reviewer-process miss that surfaced during this PR.

New commit: aa61352 (docs: require PR discussion comments in reviews)

What it changes:

AGENT.md: reviewer step now…

codex commented on issue thuanle/claw-email#16

2026-04-28 06:06:17 +07:00

Reviewer workflow must read PR discussion comments before posting verdict

Implemented on branch feat/adr-workflow and delivered via PR #15.

What changed:

AGENT.md reviewer section now explicitly requires reading PR discussion comments.
`.codex/skills/review-pr/S…

codex commented on issue thuanle/claw-email#16

2026-04-28 06:04:28 +07:00

Reviewer workflow must read PR discussion comments before posting verdict

Implementation Plan

Update AGENT.md reviewer steps so PR discussion comments are part of required review context.
Update .codex/skills/review-pr/SKILL.md workflow to load PR discussion…

codex commented on issue thuanle/claw-email#16

2026-04-28 06:04:16 +07:00

Reviewer workflow must read PR discussion comments before posting verdict

Final Requirements

Summary: Update reviewer workflow so PR discussion comments are always read before a verdict is posted.

Scope:

Update AGENT.md reviewer process to mention PR…

codex opened issue thuanle/claw-email#16

2026-04-28 06:04:00 +07:00

Reviewer workflow must read PR discussion comments before posting verdict

codex commented on pull request thuanle/claw-email#15

2026-04-28 05:54:23 +07:00

Add ADR workflow, update skills, rename do-task to implement-task

Review update:

codex suggested changes for thuanle/claw-email#15

2026-04-28 05:51:55 +07:00

Add ADR workflow, update skills, rename do-task to implement-task

FAIL

codex commented on pull request public/crypto-price-bot#27

2026-04-27 09:53:16 +07:00

refactor: standardize market file naming by data dimension

PASS

No blocking issues found in the latest update. The previous review feedback has been addressed:

trading_pairs_test.go was renamed to pairs_test.go.
Dead alphaCacheRefreshLoop was…

codex commented on pull request public/crypto-price-bot#27

2026-04-27 09:48:17 +07:00

refactor: standardize market file naming by data dimension

FAIL

[Medium] internal/data/market/trading_pairs_test.go still keeps the old trading_pairs filename even though trading_pairs.go was removed. The tests now cover shared canonical symbol…

codex commented on issue public/crypto-price-bot#26

2026-04-27 05:07:42 +07:00

Refactor market package filenames for consistent data-dimension naming

Mình đã rà lại code hiện tại sau PR canonical maps.

Issue này vẫn hợp lý, nhưng nên chỉnh scope một chút: trading_pairs.go hiện không chỉ là “trading pairs” nữa mà đang chứa…

codex commented on pull request public/crypto-price-bot#25

2026-04-27 04:59:24 +07:00

fix: recognize spot-only tokens in IsToken

PASS

No blocking issues found in the latest update. The futures cache now preserves raw futures-token identity, and spot-to-future alias lookup is explicit via SpotToken2FutureTokenMap.

Validat…

codex commented on pull request public/crypto-price-bot#25

2026-04-27 04:50:27 +07:00

fix: recognize spot-only tokens in IsToken

[codex] follow-up review for PR #25.

FAIL

[High] The canonical futures cache is currently normalized in the wrong direction. In refreshFuturePairCache, LUNA2USDT is parsed as token…

codex commented on pull request public/crypto-price-bot#25

2026-04-27 04:06:23 +07:00

fix: recognize spot-only tokens in IsToken

[codex] review results for PR #25.

FAIL

[Medium] internal/helper/binancex/symbol.go: IsToken now relies on Token2SpotSymbols, but Token2SpotSymbols itself calls Token2FutureSymbols.…

codex commented on pull request public/crypto-price-bot#23

2026-04-27 03:47:59 +07:00

Refactor Binance symbol resolver

[codex] review results for PR #23.

PASS

No blocking issues found in the latest update. The previous requested test coverage has been added, and the stale request-changes review is addressed by…