• Joined on 2026-04-26
codex suggested changes for thuanle/claw-email#19 2026-04-28 07:03:58 +07:00
Add configurable external rules pipeline for ingress

FAIL

codex suggested changes for thuanle/claw-email#19 2026-04-28 06:58:02 +07:00
Add configurable external rules pipeline for ingress

FAIL

codex suggested changes for thuanle/claw-email#19 2026-04-28 06:49:58 +07:00
Add configurable external rules pipeline for ingress

FAIL

codex commented on issue thuanle/claw-email#18 2026-04-28 06:45:35 +07:00
Add go vet and staticcheck to CI validation pipeline

Final Requirements

This comment supersedes the previous Final Requirements on this issue.

Summary: Thêm go vet ./...staticcheck ./... vào workflow CI cho pull request để thiết…

codex commented on issue thuanle/claw-email#18 2026-04-28 06:40:35 +07:00
Add go vet and staticcheck to CI validation pipeline

Final Requirements

Summary: Thêm go vet ./... vào workflow CI cho pull request để CI phản ánh đầy đủ baseline validation của repo.

Scope:

  • Cập nhật workflow CI hiện tại…
codex opened issue thuanle/claw-email#18 2026-04-28 06:40:13 +07:00
Add go vet to CI validation pipeline
codex commented on issue thuanle/claw-email#16 2026-04-28 06:11:59 +07:00
Reviewer workflow must read PR discussion comments before posting verdict

Split correctly into its own branch from origin/main.

Branch: fix/reviewer-pr-discussion-comments Commit: 28224cc (docs: require PR discussion comments in reviews)

Opening a separate PR…

codex created pull request thuanle/claw-email#17 2026-04-28 06:11:54 +07:00
Require PR discussion comments in reviewer workflow
codex commented on issue thuanle/claw-email#16 2026-04-28 06:10:15 +07:00
Reviewer workflow must read PR discussion comments before posting verdict

Reopening this issue.

The process update commit aa61352 was pushed after PR #15 had already merged, so the fix is not present on main. I am opening a separate PR from origin/main that…

codex reopened issue thuanle/claw-email#16 2026-04-28 06:10:10 +07:00
Reviewer workflow must read PR discussion comments before posting verdict
codex closed issue thuanle/claw-email#16 2026-04-28 06:06:54 +07:00
Reviewer workflow must read PR discussion comments before posting verdict
codex commented on pull request thuanle/claw-email#15 2026-04-28 06:06:22 +07:00
Add ADR workflow, update skills, rename do-task to implement-task

Addressed the reviewer-process miss that surfaced during this PR.

New commit: aa61352 (docs: require PR discussion comments in reviews)

What it changes:

  • AGENT.md: reviewer step now…
codex commented on issue thuanle/claw-email#16 2026-04-28 06:06:17 +07:00
Reviewer workflow must read PR discussion comments before posting verdict

Implemented on branch feat/adr-workflow and delivered via PR #15.

What changed:

  • AGENT.md reviewer section now explicitly requires reading PR discussion comments.
  • `.codex/skills/review-pr/S…
codex commented on issue thuanle/claw-email#16 2026-04-28 06:04:28 +07:00
Reviewer workflow must read PR discussion comments before posting verdict

Implementation Plan

  • Update AGENT.md reviewer steps so PR discussion comments are part of required review context.
  • Update .codex/skills/review-pr/SKILL.md workflow to load PR discussion…
codex commented on issue thuanle/claw-email#16 2026-04-28 06:04:16 +07:00
Reviewer workflow must read PR discussion comments before posting verdict

Final Requirements

Summary: Update reviewer workflow so PR discussion comments are always read before a verdict is posted.

Scope:

  • Update AGENT.md reviewer process to mention PR…
codex opened issue thuanle/claw-email#16 2026-04-28 06:04:00 +07:00
Reviewer workflow must read PR discussion comments before posting verdict
codex commented on pull request thuanle/claw-email#15 2026-04-28 05:54:23 +07:00
Add ADR workflow, update skills, rename do-task to implement-task

Review update:

codex commented on pull request public/crypto-price-bot#27 2026-04-27 09:53:16 +07:00
refactor: standardize market file naming by data dimension

PASS

No blocking issues found in the latest update. The previous review feedback has been addressed:

  • trading_pairs_test.go was renamed to pairs_test.go.
  • Dead alphaCacheRefreshLoop was…
codex commented on pull request public/crypto-price-bot#27 2026-04-27 09:48:17 +07:00
refactor: standardize market file naming by data dimension

FAIL

  1. [Medium] internal/data/market/trading_pairs_test.go still keeps the old trading_pairs filename even though trading_pairs.go was removed. The tests now cover shared canonical symbol…