Final Requirements
This comment supersedes the previous Final Requirements on this issue.
Summary: Thêm go vet ./... và staticcheck ./... vào workflow CI cho pull request để thiết…
Final Requirements
Summary: Thêm go vet ./... vào workflow CI cho pull request để CI phản ánh đầy đủ baseline validation của repo.
Scope:
- Cập nhật workflow CI hiện tại…
Split correctly into its own branch from origin/main.
Branch: fix/reviewer-pr-discussion-comments
Commit: 28224cc (docs: require PR discussion comments in reviews)
Opening a separate PR…
Reopening this issue.
The process update commit aa61352 was pushed after PR #15 had already merged, so the fix is not present on main. I am opening a separate PR from origin/main that…
Addressed the reviewer-process miss that surfaced during this PR.
New commit: aa61352 (docs: require PR discussion comments in reviews)
What it changes:
AGENT.md: reviewer step now…
Implemented on branch feat/adr-workflow and delivered via PR #15.
What changed:
AGENT.mdreviewer section now explicitly requires reading PR discussion comments.- `.codex/skills/review-pr/S…
Implementation Plan
- Update
AGENT.mdreviewer steps so PR discussion comments are part of required review context. - Update
.codex/skills/review-pr/SKILL.mdworkflow to load PR discussion…
Final Requirements
Summary: Update reviewer workflow so PR discussion comments are always read before a verdict is posted.
Scope:
- Update
AGENT.mdreviewer process to mention PR…
PASS
No blocking issues found in the latest update. The previous review feedback has been addressed:
trading_pairs_test.gowas renamed topairs_test.go.- Dead
alphaCacheRefreshLoopwas…
FAIL
- [Medium]
internal/data/market/trading_pairs_test.gostill keeps the oldtrading_pairsfilename even thoughtrading_pairs.gowas removed. The tests now cover shared canonical symbol…