public/crypto-price-bot
6
0
Fork 0
Code Issues 1 Pull Requests 2 Actions Packages Projects Releases Wiki Activity

Remove ETH special portfolio tracking #16

Merged
thuanle merged 2 commits from chore/remove-eth-special-case into main 2026-04-26 16:45:36 +07:00
Conversation 1 Commits 2 Files Changed 1
-51
thuanle commented 2026-04-26 15:14:48 +07:00
Owner
Copy Link
Copy Source

Summary

  • Remove personal portfolio calculations (Real + Trang Bức balance, Road to 5k) from ETH price display
  • ETH now treated like any other token — shows only spot/future price and funding rate

Test plan

  • Send "eth" — should show standard price format without portfolio info
## Summary - Remove personal portfolio calculations (Real + Trang Bức balance, Road to 5k) from ETH price display - ETH now treated like any other token — shows only spot/future price and funding rate ## Test plan - [ ] Send "eth" — should show standard price format without portfolio info
thuanle added 1 commit 2026-04-26 15:14:49 +07:00
Remove ETH special portfolio tracking 59da49c17f 
Treat ETH like any other token — display only spot/future price
and funding rate, removing personal portfolio calculations.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
thuanle commented 2026-04-26 16:45:00 +07:00
Author
Owner
Copy Link
Copy Source

As Reviewer, here is the result for PR #16.

PASS

No blocking issues found in the latest update.

Validation:

  • Reviewed against latest origin/main after git fetch origin
  • go test ./... passed on a temp snapshot of origin/chore/remove-eth-special-case
  • go vet ./... passed on the same snapshot

Non-blocking note:

  • There are still no automated behavior tests for the Telegram ETH response, so this user-facing change is covered only by manual verification from the PR test plan.
As Reviewer, here is the result for PR #16. PASS No blocking issues found in the latest update. Validation: - Reviewed against latest origin/main after git fetch origin - go test ./... passed on a temp snapshot of origin/chore/remove-eth-special-case - go vet ./... passed on the same snapshot Non-blocking note: - There are still no automated behavior tests for the Telegram ETH response, so this user-facing change is covered only by manual verification from the PR test plan.
thuanle added 1 commit 2026-04-26 16:45:28 +07:00
Merge branch 'main' into chore/remove-eth-special-case 4cab108549
thuanle merged commit ee6c181cd6 into main 2026-04-26 16:45:36 +07:00
thuanle deleted branch chore/remove-eth-special-case 2026-04-26 17:12:04 +07:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
antigravity claudecode codex devops renovatebot thuanle
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: public/crypto-price-bot#16
Delete Branch "chore/remove-eth-special-case"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?