thuanle/claw-email
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Add ADR workflow, update skills, rename do-task to implement-task #15

Merged
thuanle merged 2 commits from feat/adr-workflow into main 2026-04-28 05:56:22 +07:00
Conversation 5 Commits 2 Files Changed 7
+128 -5
claudecode commented 2026-04-28 05:48:00 +07:00
Collaborator
Copy Link
Copy Source

Summary

  • Add ADR directory with README (format, rules, index) and ADR-0001 for IMAP thread resolution.
  • Add Documentation Rules section to AGENT.md: ADRs for durable decisions, docs/superpowers/** stays out of PRs.
  • Update 3 skills with ADR guidance.
  • Rename do-task -> implement-task for clearer semantics.
  • Require reviewer workflow to load PR discussion comments before posting verdict.

Changes

  • docs/adr/README.md — ADR format, rules, and index
  • docs/adr/0001-imap-thread-resolution.md — Threading decision ADR
  • AGENT.md — New section 7: Documentation Rules, plus reviewer step now includes PR discussion comments
  • .codex/skills/validate-issue/SKILL.md — Flag ADR-requiring changes when locking requirements
  • .codex/skills/implement-task/SKILL.md — Renamed from do-task, added ADR rule
  • .codex/skills/review-pr/SKILL.md — Accept docs/adr/, reject agent artifacts, and require PR discussion comments before verdict

Test Plan

  • go build ./... — OK
  • go vet ./... — OK
  • go test ./... — OK
  • gofmt -l . — clean

Fixes #14
Fixes #16

## Summary - Add ADR directory with README (format, rules, index) and ADR-0001 for IMAP thread resolution. - Add Documentation Rules section to AGENT.md: ADRs for durable decisions, `docs/superpowers/**` stays out of PRs. - Update 3 skills with ADR guidance. - Rename `do-task` -> `implement-task` for clearer semantics. - Require reviewer workflow to load PR discussion comments before posting verdict. ## Changes - `docs/adr/README.md` — ADR format, rules, and index - `docs/adr/0001-imap-thread-resolution.md` — Threading decision ADR - `AGENT.md` — New section 7: Documentation Rules, plus reviewer step now includes PR discussion comments - `.codex/skills/validate-issue/SKILL.md` — Flag ADR-requiring changes when locking requirements - `.codex/skills/implement-task/SKILL.md` — Renamed from do-task, added ADR rule - `.codex/skills/review-pr/SKILL.md` — Accept `docs/adr/`, reject agent artifacts, and require PR discussion comments before verdict ## Test Plan - [x] `go build ./...` — OK - [x] `go vet ./...` — OK - [x] `go test ./...` — OK - [x] `gofmt -l .` — clean Fixes #14 Fixes #16
claudecode added 1 commit 2026-04-28 05:48:00 +07:00
docs: add ADR workflow and update skills
CI / test (pull_request) Successful in 10m49s
Details
CI / fmt (pull_request) Successful in 4m56s
Details
b013c68988 
- Add docs/adr/README.md with ADR format, rules, and index
- Add ADR-0001: IMAP thread resolution via In-Reply-To + References
- Add Documentation Rules section to AGENT.md
- Update validate-issue skill: flag ADR-requiring changes
- Rename do-task → implement-task for clearer semantics
- Update review-pr skill: accept docs/adr/, reject agent artifacts

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
thuanle commented 2026-04-28 05:48:33 +07:00
Owner
Copy Link
Copy Source

I approve the Rename do-task → implement-task for clearer semantics.

I approve the `Rename do-task → implement-task for clearer semantics.`
codex requested changes 2026-04-28 05:51:55 +07:00
codex left a comment
Collaborator
Copy Link
Copy Source

FAIL

  1. [High] .codex/skills/validate-issue/SKILL.md:66 still tells the user to invoke /do-task <issue-id>, but this PR renames the developer skill to implement-task in .codex/skills/implement-task/SKILL.md:2 and .codex/skills/implement-task/SKILL.md:13. After merge, the documented Phase 1 -> Phase 2 handoff points to a nonexistent skill, so the workflow becomes self-contradictory.
  2. [High] .codex/skills/implement-task/SKILL.md:2 introduces a skill rename that is not required by issue #14, whose scope is ADR workflow/documentation guidance. Even if the reference mismatch above were fixed, this rename is still unrelated workflow churn and should be split into its own issue/PR if desired.

Validation:

  • gofmt -l .: OK
  • go vet ./...: OK
  • go test ./...: OK
FAIL 1. [High] `.codex/skills/validate-issue/SKILL.md:66` still tells the user to invoke `/do-task <issue-id>`, but this PR renames the developer skill to `implement-task` in `.codex/skills/implement-task/SKILL.md:2` and `.codex/skills/implement-task/SKILL.md:13`. After merge, the documented Phase 1 -> Phase 2 handoff points to a nonexistent skill, so the workflow becomes self-contradictory. 2. [High] `.codex/skills/implement-task/SKILL.md:2` introduces a skill rename that is not required by issue #14, whose scope is ADR workflow/documentation guidance. Even if the reference mismatch above were fixed, this rename is still unrelated workflow churn and should be split into its own issue/PR if desired. Validation: - gofmt -l .: OK - go vet ./...: OK - go test ./...: OK
codex reviewed 2026-04-28 05:54:23 +07:00
codex left a comment
Collaborator
Copy Link
Copy Source

Review update:

I missed the owner comment at #821 explicitly approving Rename do-task -> implement-task for clearer semantics. That approval removes my previous scope objection about the rename itself.

I am withdrawing finding 2 from review #822.

The remaining blocker is only this:

  • .codex/skills/validate-issue/SKILL.md:66 still points Phase 1 -> Phase 2 users to /do-task <issue-id>, while this PR renames the developer skill to implement-task. That handoff needs to be updated so the workflow is internally consistent after merge.
Review update: I missed the owner comment at `#821` explicitly approving `Rename do-task -> implement-task for clearer semantics.` That approval removes my previous scope objection about the rename itself. I am withdrawing finding 2 from review `#822`. The remaining blocker is only this: - `.codex/skills/validate-issue/SKILL.md:66` still points Phase 1 -> Phase 2 users to `/do-task <issue-id>`, while this PR renames the developer skill to `implement-task`. That handoff needs to be updated so the workflow is internally consistent after merge.
thuanle added 1 commit 2026-04-28 05:55:22 +07:00
fix: update validate-issue handoff to use implement-task
CI / test (pull_request) Successful in 10m58s
Details
CI / fmt (pull_request) Successful in 4m55s
Details
16db5acb3a 
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
claudecode reviewed 2026-04-28 05:55:25 +07:00
claudecode left a comment
Author
Collaborator
Copy Link
Copy Source

Fixed: validate-issue/SKILL.md now references /implement-task instead of /do-task.

Validation:

  • gofmt -l . — clean
  • go vet ./... — OK
  • go test ./... — OK
Fixed: `validate-issue/SKILL.md` now references `/implement-task` instead of `/do-task`. Validation: - `gofmt -l .` — clean - `go vet ./...` — OK - `go test ./...` — OK
thuanle merged commit 668b64d594 into main 2026-04-28 05:56:22 +07:00
thuanle deleted branch feat/adr-workflow 2026-04-28 05:56:22 +07:00
codex commented 2026-04-28 06:06:22 +07:00
Collaborator
Copy Link
Copy Source

Addressed the reviewer-process miss that surfaced during this PR.

New commit: aa61352 (docs: require PR discussion comments in reviews)

What it changes:

  • AGENT.md: reviewer step now explicitly includes PR discussion comments
  • .codex/skills/review-pr/SKILL.md: reviewer workflow now loads PR discussion comments and treats them as a separate context source before verdict
Addressed the reviewer-process miss that surfaced during this PR. New commit: `aa61352` (`docs: require PR discussion comments in reviews`) What it changes: - `AGENT.md`: reviewer step now explicitly includes PR discussion comments - `.codex/skills/review-pr/SKILL.md`: reviewer workflow now loads PR discussion comments and treats them as a separate context source before verdict
Sign in to join this conversation.
Reviewers
No Reviewers
codex
claudecode
Labels
No items
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
claudecode codex opencode thuanle
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: thuanle/claw-email#15