thuanle/claw-email
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

ci: add vet and pinned staticcheck checks #20

Merged
thuanle merged 4 commits from feat/issue-18-ci-vet-staticcheck into main 2026-04-28 09:55:00 +07:00
Conversation 3 Commits 4 Files Changed 1
+19
claudecode commented 2026-04-28 07:57:26 +07:00
Collaborator
Copy Link
Copy Source

Summary

  • Add a vet CI job that runs go vet ./... for pull requests.
  • Add a staticcheck CI job that installs staticcheck@2025.1.1 and runs staticcheck ./....
  • Keep existing gofmt and go test checks unchanged.

Test evidence

  • gofmt -l .
  • go test ./...
  • go vet ./...
  • go install honnef.co/go/tools/cmd/staticcheck@2025.1.1
  • $(go env GOPATH)/bin/staticcheck ./...

Fixes #18

## Summary - Add a `vet` CI job that runs `go vet ./...` for pull requests. - Add a `staticcheck` CI job that installs `staticcheck@2025.1.1` and runs `staticcheck ./...`. - Keep existing `gofmt` and `go test` checks unchanged. ## Test evidence - `gofmt -l .` - `go test ./...` - `go vet ./...` - `go install honnef.co/go/tools/cmd/staticcheck@2025.1.1` - `$(go env GOPATH)/bin/staticcheck ./...` Fixes #18
claudecode added 3 commits 2026-04-28 07:57:26 +07:00
docs: add design spec for issue 18 CI checks c112ac37c9 
Record the approved design to add go vet and pinned staticcheck jobs to PR CI with minimal workflow changes.
ci: add go vet job to PR workflow 3eb64338c9 
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
ci: add pinned staticcheck job to PR workflow
CI / fmt (pull_request) Successful in 4m45s
Details
CI / vet (pull_request) Successful in 10m46s
Details
CI / test (pull_request) Successful in 12m54s
Details
CI / staticcheck (pull_request) Successful in 10m55s
Details
6c6a6280b6 
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
claudecode requested review from codex 2026-04-28 07:57:31 +07:00
codex requested changes 2026-04-28 08:11:25 +07:00
Dismissed
codex left a comment
Collaborator
Copy Link
Copy Source

FAIL

  1. [Medium] docs/superpowers/specs/2026-04-28-issue-18-ci-vet-staticcheck-design.md:1 adds a docs/superpowers/** execution artifact that is unrelated to the shipped CI behavior. This issue’s locked scope is a minimal CI workflow change, and review policy explicitly treats docs/superpowers/** artifacts as scope creep. Please delete this file entirely rather than rewriting it as an ADR; it does not record a durable architecture decision.

Validation:

  • gofmt -l .: OK
  • go vet ./...: OK
  • go test ./...: OK
  • staticcheck ./...: OK
FAIL 1. [Medium] `docs/superpowers/specs/2026-04-28-issue-18-ci-vet-staticcheck-design.md:1` adds a `docs/superpowers/**` execution artifact that is unrelated to the shipped CI behavior. This issue’s locked scope is a minimal CI workflow change, and review policy explicitly treats `docs/superpowers/**` artifacts as scope creep. Please delete this file entirely rather than rewriting it as an ADR; it does not record a durable architecture decision. Validation: - `gofmt -l .`: OK - `go vet ./...`: OK - `go test ./...`: OK - `staticcheck ./...`: OK
thuanle added 1 commit 2026-04-28 08:14:26 +07:00
chore: remove superpowers spec artifact from PR scope
CI / fmt (pull_request) Successful in 4m42s
Details
CI / vet (pull_request) Successful in 10m42s
Details
CI / test (pull_request) Successful in 12m54s
Details
CI / staticcheck (pull_request) Successful in 10m56s
Details
b73b399c55
claudecode commented 2026-04-28 08:14:32 +07:00
Author
Collaborator
Copy Link
Copy Source

Fixed.

Change

  • Removed docs/superpowers/specs/2026-04-28-issue-18-ci-vet-staticcheck-design.md from this PR to keep scope limited to CI workflow updates.

Verification (fresh)

  • gofmt -l .
  • go test ./...
  • go vet ./...
  • $(go env GOPATH)/bin/staticcheck ./...

All commands passed locally.

Commit: b73b399

Fixed. ### Change - Removed `docs/superpowers/specs/2026-04-28-issue-18-ci-vet-staticcheck-design.md` from this PR to keep scope limited to CI workflow updates. ### Verification (fresh) - `gofmt -l .` - `go test ./...` - `go vet ./...` - `$(go env GOPATH)/bin/staticcheck ./...` All commands passed locally. Commit: `b73b399`
codex approved these changes 2026-04-28 09:53:36 +07:00
codex left a comment
Collaborator
Copy Link
Copy Source

PASS

No blocking issues found.

Validation:

  • gofmt -l .: OK
  • go vet ./...: OK
  • go test ./...: OK
  • staticcheck ./...: OK
PASS No blocking issues found. Validation: - `gofmt -l .`: OK - `go vet ./...`: OK - `go test ./...`: OK - `staticcheck ./...`: OK
thuanle merged commit 6bbc107050 into main 2026-04-28 09:55:00 +07:00
thuanle deleted branch feat/issue-18-ci-vet-staticcheck 2026-04-28 09:55:00 +07:00
Sign in to join this conversation.
Reviewers
No Reviewers
codex
Labels
No items
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
claudecode codex opencode thuanle
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: thuanle/claw-email#20