thuanle
0 Followers · 0 Following
  • Joined on 2024-10-11
Repositories
2
 Projects Packages Public Activity Starred Repositories
1
thuanle merged pull request public/crypto-price-bot#13 2026-04-26 16:51:23 +07:00
Update module github.com/go-resty/resty/v2 to v2.17.2
93b6c42842 Update module github.com/go-resty/resty/v2 to v2.17.2
ee6c181cd6 Merge pull request 'Remove ETH special portfolio tracking' (#16) from chore/remove-eth-special-case into main
4cab108549 Merge branch 'main' into chore/remove-eth-special-case
733cf48e41 Merge pull request 'Rewrite price lookup from WebSocket to REST API' (#15) from feat/rest-price-lookup into main
914beea5ce Address PR #15 round 2: fail-closed admin guard, sync init, error reporting
Compare 8 commits »
0579a1163c Update module github.com/jedib0t/go-pretty/v6 to v6.7.10
ee6c181cd6 Merge pull request 'Remove ETH special portfolio tracking' (#16) from chore/remove-eth-special-case into main
4cab108549 Merge branch 'main' into chore/remove-eth-special-case
733cf48e41 Merge pull request 'Rewrite price lookup from WebSocket to REST API' (#15) from feat/rest-price-lookup into main
914beea5ce Address PR #15 round 2: fail-closed admin guard, sync init, error reporting
Compare 8 commits »
thuanle pushed to main at public/crypto-price-bot 2026-04-26 16:45:37 +07:00
ee6c181cd6 Merge pull request 'Remove ETH special portfolio tracking' (#16) from chore/remove-eth-special-case into main
4cab108549 Merge branch 'main' into chore/remove-eth-special-case
59da49c17f Remove ETH special portfolio tracking
Compare 3 commits »
thuanle merged pull request public/crypto-price-bot#16 2026-04-26 16:45:36 +07:00
Remove ETH special portfolio tracking
thuanle pushed to chore/remove-eth-special-case at public/crypto-price-bot 2026-04-26 16:45:28 +07:00
4cab108549 Merge branch 'main' into chore/remove-eth-special-case
733cf48e41 Merge pull request 'Rewrite price lookup from WebSocket to REST API' (#15) from feat/rest-price-lookup into main
914beea5ce Address PR #15 round 2: fail-closed admin guard, sync init, error reporting
c7128ff516 Address PR #15 review: batch API calls and admin-guard /refresh
9c39423315 Rewrite price lookup from WebSocket to REST API
Compare 5 commits »
thuanle commented on pull request public/crypto-price-bot#16 2026-04-26 16:45:00 +07:00
Remove ETH special portfolio tracking

As Reviewer, here is the result for PR #16.

PASS

No blocking issues found in the latest update.

Validation:

  • Reviewed against latest origin/main after git fetch origin
  • go test ./... passed…
thuanle pushed to main at public/crypto-price-bot 2026-04-26 16:19:30 +07:00
733cf48e41 Merge pull request 'Rewrite price lookup from WebSocket to REST API' (#15) from feat/rest-price-lookup into main
914beea5ce Address PR #15 round 2: fail-closed admin guard, sync init, error reporting
c7128ff516 Address PR #15 review: batch API calls and admin-guard /refresh
9c39423315 Rewrite price lookup from WebSocket to REST API
Compare 4 commits »
thuanle merged pull request public/crypto-price-bot#15 2026-04-26 16:19:28 +07:00
Rewrite price lookup from WebSocket to REST API
thuanle commented on pull request public/crypto-price-bot#15 2026-04-26 16:19:03 +07:00
Rewrite price lookup from WebSocket to REST API

PASS

Reviewed latest update in commit 914beea.

The previously reported blocking issues are fixed:

  • /refresh admin guard is now fail-closed.
  • Initial trading-pair cache load is now…
thuanle commented on pull request public/crypto-price-bot#15 2026-04-26 16:03:35 +07:00
Rewrite price lookup from WebSocket to REST API

Addressed all 3 issues in 914beea: (1) /refresh is now fail-closed — if ADMIN_CHAT_ID is unset or invalid, the command rejects all requests. (2) Initial pair cache fill is synchronous in…

thuanle pushed to feat/rest-price-lookup at public/crypto-price-bot 2026-04-26 16:03:24 +07:00
914beea5ce Address PR #15 round 2: fail-closed admin guard, sync init, error reporting
thuanle commented on pull request public/crypto-price-bot#15 2026-04-26 15:57:46 +07:00
Rewrite price lookup from WebSocket to REST API

FAIL

  1. internal/services/tele/commands/market.go:26-28: /refresh admin guard is fail-open. If ADMIN_CHAT_ID is unset or invalid, ParseInt returns 0 and any user can call /refresh.

2.…

thuanle commented on pull request public/crypto-price-bot#15 2026-04-26 15:46:17 +07:00
Rewrite price lookup from WebSocket to REST API

Thanks for the review. Addressed both [High] items in c7128ff: (1) Added GetAllPremiumIndex for single batch API call instead of per-symbol sequential calls. (2) Added ADMIN_CHAT_ID env check to…

thuanle pushed to feat/rest-price-lookup at public/crypto-price-bot 2026-04-26 15:40:08 +07:00
c7128ff516 Address PR #15 review: batch API calls and admin-guard /refresh
thuanle commented on pull request public/crypto-price-bot#15 2026-04-26 15:36:42 +07:00
Rewrite price lookup from WebSocket to REST API

Request changes.

  1. [High] /p đang thực hiện nhiều REST call tuần tự cho từng symbol. Binance futures premium index API hỗ trợ lấy nhiều pair trong một lần gọi (không truyền…
thuanle created pull request public/crypto-price-bot#16 2026-04-26 15:14:49 +07:00
Remove ETH special portfolio tracking
thuanle created branch chore/remove-eth-special-case in public/crypto-price-bot 2026-04-26 15:14:44 +07:00
thuanle pushed to chore/remove-eth-special-case at public/crypto-price-bot 2026-04-26 15:14:44 +07:00
59da49c17f Remove ETH special portfolio tracking
thuanle created pull request public/crypto-price-bot#15 2026-04-26 15:14:29 +07:00
Rewrite price lookup from WebSocket to REST API