Block a user
thuanle
created branch binance-symbol-resolver-refactor in public/crypto-price-bot
2026-04-27 03:32:03 +07:00
thuanle
pushed to feat/issue-21-shared-symbol-resolver at public/crypto-price-bot
2026-04-26 21:04:32 +07:00
fix: resolve shared symbol mapping for token command
[claudecode gpt-5.3-codex] Đã xử lý xong conflict với main.
Changes
- Rebase branch
feat/issue-21-shared-symbol-resolverlênorigin/main - Resolve conflict tại:
- `internal/services…
thuanle
pushed to feat/issue-21-shared-symbol-resolver at public/crypto-price-bot
2026-04-26 20:43:14 +07:00
1486681ef9
Merge pull request 'fix: independent token source lookups' (#19) from feat/token-message-rich into main
fix: resolve shared symbol mapping for token command
thuanle
pushed to feat/issue-21-shared-symbol-resolver at public/crypto-price-bot
2026-04-26 20:35:23 +07:00
thuanle
created branch feat/issue-21-shared-symbol-resolver in public/crypto-price-bot
2026-04-26 20:35:23 +07:00
Token collector bypasses existing spot/future symbol resolution rules
[claudecode gpt-5.3-codex]
Kế hoạch xử lý (chưa implement)
Mình đã viết plan đầy đủ theo hướng mới: không reuse trực tiếp 2 helper cũ ở command, thay vào đó tạo **shared…
Token collector bypasses existing spot/future symbol resolution rules
[claudecode gpt-5.3-codex]
Scope alignment
Chốt lại scope theo định hướng mới:
- Alpha lookup giữ độc lập: không cần ép đồng nhất symbol với Spot/Future.
- **Spot/Future…
Token collector bypasses existing spot/future symbol resolution rules
Legacy Issue: Một số Token sẽ có symbol khác nhau cho Spot và Future, và có thể alpha
Ví dụ
- Luna trong spot là LUNA_USDT, trong future là luna2USDT
- Một số đồng có thêm tiền…
Token collector bypasses existing spot/future symbol resolution rules
[claudecode gpt-5.3-codex]
Ý kiến
Mình đồng ý với issue này: hiện tại collectRichTokenData đang assume token+USDT cho cả spot/future nên có thể làm rơi các case mapping đặc…
Rich token message handler cannot reach spot-only fallback
Rich token message handler cannot reach spot-only fallback
[claudecode gpt-5.3-codex]
Summary
Issue này đã được xử lý qua các PR đã merge.
Changes mapped to issue
- PR #19: tách độc lập các lookup spot/future/alpha trong command handler,…
thuanle
deleted branch feat/parallel-price-lookup-v2 from public/crypto-price-bot
2026-04-26 19:15:58 +07:00
391169761a
Merge pull request 'perf: parallelize token source price requests' (#20) from feat/parallel-price-lookup-v2 into feat/token-message-rich
perf: parallelize token source price requests
perf: parallelize token source price requests
[codex] review results for PR #20.
PASS
No blocking issues found in the latest update.
Validation:
go test ./internal/services/tele/commands -run RunsLookupsConcurrently -v -count=1- `go…
thuanle
pushed to feat/parallel-price-lookup-v2 at public/crypto-price-bot
2026-04-26 19:00:47 +07:00
c841ca4421
Merge pull request 'Add rich unified token price message' (#17) from feat/token-message-rich into main
1486681ef9
Merge pull request 'fix: independent token source lookups' (#19) from feat/token-message-rich into main