thuanle
0 Followers · 0 Following
  • Joined on 2024-10-11
Repositories
2
 Projects Packages Public Activity Starred Repositories
1
thuanle merged pull request public/crypto-price-bot#19 2026-04-26 18:51:18 +07:00
fix: independent token source lookups
thuanle commented on pull request public/crypto-price-bot#19 2026-04-26 18:47:49 +07:00
fix: independent token source lookups

[codex] scope clarification for PR #19.

The concern from my previous review comment is about spot/future symbol resolution only. It is not about the new Alpha lookup itself.

More specifically,…

thuanle opened issue public/crypto-price-bot#21 2026-04-26 18:43:46 +07:00
Token collector bypasses existing spot/future symbol resolution rules
thuanle pushed to feat/token-message-rich at public/crypto-price-bot 2026-04-26 18:39:54 +07:00
a4644f5982 Merge branch 'main' into feat/token-message-rich
194a235065 docs: document required environment variables
c841ca4421 Merge pull request 'Add rich unified token price message' (#17) from feat/token-message-rich into main
Compare 3 commits »
thuanle commented on pull request public/crypto-price-bot#19 2026-04-26 18:37:38 +07:00
fix: independent token source lookups

Codex review results for PR #19.

FAIL

  1. [High] collectRichTokenData regresses existing symbol resolution by hardcoding both lookups to token + "USDT" in `internal/services/tele/commands/toke…
thuanle created pull request public/crypto-price-bot#20 2026-04-26 18:31:09 +07:00
perf: parallelize token source price requests
thuanle pushed to feat/parallel-price-lookup-v2 at public/crypto-price-bot 2026-04-26 18:26:40 +07:00
a36eb7aad0 perf: run token price source lookups in parallel
thuanle created branch feat/parallel-price-lookup-v2 in public/crypto-price-bot 2026-04-26 18:26:40 +07:00
thuanle pushed to feat/token-message-rich at public/crypto-price-bot 2026-04-26 18:22:57 +07:00
82b0f2f1a8 feat: fetch alpha price by symbol ticker
thuanle created pull request public/crypto-price-bot#19 2026-04-26 18:13:41 +07:00
fix: independent token source lookups
thuanle pushed to feat/token-message-rich at public/crypto-price-bot 2026-04-26 18:13:17 +07:00
6e8a2e8f68 fix: decouple token spot/future/alpha lookups
thuanle created branch feat/token-message-rich in public/crypto-price-bot 2026-04-26 18:13:17 +07:00
thuanle opened issue public/crypto-price-bot#18 2026-04-26 18:00:00 +07:00
Rich token message handler cannot reach spot-only fallback
thuanle pushed to main at public/crypto-price-bot 2026-04-26 17:50:44 +07:00
194a235065 docs: document required environment variables
thuanle deleted branch feat/token-message-rich from public/crypto-price-bot 2026-04-26 17:42:24 +07:00
thuanle pushed to main at public/crypto-price-bot 2026-04-26 17:41:19 +07:00
c841ca4421 Merge pull request 'Add rich unified token price message' (#17) from feat/token-message-rich into main
95e9217ef4 fix: render basis with explicit sign and absolute delta
88de029e14 feat: unify token message composition across sources
2f875032f6 feat: add rich token message renderer with conditional rows
b376eba674 Ignore local worktree directory
Compare 6 commits »
thuanle merged pull request public/crypto-price-bot#17 2026-04-26 17:41:18 +07:00
Add rich unified token price message
thuanle commented on pull request public/crypto-price-bot#17 2026-04-26 17:40:16 +07:00
Add rich unified token price message

Fixed in 95e9217. Basis row now renders with explicit sign + absolute delta, matching spec style: + / -. Also added negative-basis coverage in view tests. Re-ran validation: go test ./internal/serv…

thuanle pushed to feat/token-message-rich at public/crypto-price-bot 2026-04-26 17:40:00 +07:00
95e9217ef4 fix: render basis with explicit sign and absolute delta
thuanle commented on pull request public/crypto-price-bot#17 2026-04-26 17:35:06 +07:00
Add rich unified token price message

As Reviewer, here is the result for PR #17.

FAIL

  1. [Medium] Basis row formatting does not match the spec in internal/services/tele/view/price.go:105. The percent part is fine, but the…